From: Colin Ian King Date: Wed, 14 Nov 2018 22:17:05 +0000 (+0000) Subject: block: clean up dead code that is now redundant X-Git-Tag: v5.4-rc1~1880^2~248 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=98c98cb770da9469ee868f21299b2ba21fe438ac;p=platform%2Fkernel%2Flinux-rpi.git block: clean up dead code that is now redundant The boolean next_sorted is set to false and is never changed, hence the code that checks if it is true is dead code and can now be removed. This dead code occurred from a previous commit that cleaned up the elevator and removed the setting of next_sorted to true. Detected by CoverityScan, CID#1475401 ("'Constant' variable guards dead code") Fixes: a1ce35fa4985 ("block: remove dead elevator code") Signed-off-by: Colin Ian King Signed-off-by: Jens Axboe --- diff --git a/block/elevator.c b/block/elevator.c index 19351ff..7964362 100644 --- a/block/elevator.c +++ b/block/elevator.c @@ -394,18 +394,11 @@ void elv_merge_requests(struct request_queue *q, struct request *rq, struct request *next) { struct elevator_queue *e = q->elevator; - bool next_sorted = false; if (e->type->ops.requests_merged) e->type->ops.requests_merged(q, rq, next); elv_rqhash_reposition(q, rq); - - if (next_sorted) { - elv_rqhash_del(q, next); - q->nr_sorted--; - } - q->last_merge = rq; }