From: Chen Gang Date: Wed, 3 Jul 2013 22:04:53 +0000 (-0700) Subject: arch/frv/kernel/setup.c: use strncmp() instead of memcmp() X-Git-Tag: accepted/tizen/common/20141203.182822~1935^2~263 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=98bd8d05ea5798ff3179ee33f0ca2789722ecc5a;p=platform%2Fkernel%2Flinux-arm64.git arch/frv/kernel/setup.c: use strncmp() instead of memcmp() 'cmdline' is a NUL terminated string, when its length < 4, memcmp() will cause memory access out of boundary. So use strncmp() instead of memcmp(). Signed-off-by: Chen Gang Cc: David Howells Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/arch/frv/kernel/setup.c b/arch/frv/kernel/setup.c index f78f8cb..ae3a670 100644 --- a/arch/frv/kernel/setup.c +++ b/arch/frv/kernel/setup.c @@ -735,7 +735,7 @@ static void __init parse_cmdline_early(char *cmdline) /* "mem=XXX[kKmM]" sets SDRAM size to , overriding the value we worked * out from the SDRAM controller mask register */ - if (!memcmp(cmdline, "mem=", 4)) { + if (!strncmp(cmdline, "mem=", 4)) { unsigned long long mem_size; mem_size = memparse(cmdline + 4, &cmdline);