From: Dan Albert Date: Thu, 18 Oct 2018 18:04:28 +0000 (+0000) Subject: [compiler-rt] Don't explicitly set CMAKE_CXX_FLAGS. X-Git-Tag: llvmorg-8.0.0-rc1~6299 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=98a6692380d7d6d8f92c6cc8b77f4e8ec3ca0a05;p=platform%2Fupstream%2Fllvm.git [compiler-rt] Don't explicitly set CMAKE_CXX_FLAGS. Summary: C++ flags should not be used for not-C++ files as it may trigger -Werror=unused-command-line-argument. CMake will use CMAKE_C_FLAGS, CMAKE_CXX_FLAGS, and CMAKE_ASM_FLAGS as appropriate implicitly, so this does not need to be explicitly handled here. This change depends on https://reviews.llvm.org/D53301, since one of the builders depended on this behavior because it was not configuring CMAKE_ASM_FLAGS. Reviewers: eugenis, vitalybuka Reviewed By: eugenis, vitalybuka Subscribers: dberris, mgorny, delcypher, #sanitizers, llvm-commits Differential Revision: https://reviews.llvm.org/D53335 llvm-svn: 344751 --- diff --git a/compiler-rt/cmake/Modules/AddCompilerRT.cmake b/compiler-rt/cmake/Modules/AddCompilerRT.cmake index 4efbd3a..4d4222d 100644 --- a/compiler-rt/cmake/Modules/AddCompilerRT.cmake +++ b/compiler-rt/cmake/Modules/AddCompilerRT.cmake @@ -77,7 +77,7 @@ function(add_compiler_rt_object_libraries name) endif() set_target_compile_flags(${libname} - ${CMAKE_CXX_FLAGS} ${extra_cflags_${libname}} ${target_flags}) + ${extra_cflags_${libname}} ${target_flags}) set_property(TARGET ${libname} APPEND PROPERTY COMPILE_DEFINITIONS ${LIB_DEFS}) set_target_properties(${libname} PROPERTIES FOLDER "Compiler-RT Libraries")