From: Márton Németh Date: Thu, 26 May 2011 07:24:45 +0000 (+0200) Subject: usbip: remove check for negative values for an unsigned value X-Git-Tag: upstream/snapshot3+hdmi~9540^2~568^2~21 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=988e7520818c4e9ac6d4b195376a46bb24a0dd99;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git usbip: remove check for negative values for an unsigned value The parameter rhport is unsigned so there is no need checking for negative values. This will remove the following warning message when compiling with "make W=1 ...": drivers/staging/usbip/vhci_sysfs.c: In function ‘valid_args’: drivers/staging/usbip/vhci_sysfs.c:138: warning: comparison of unsigned expression < 0 is always false Signed-off-by: Márton Németh Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/usbip/vhci_sysfs.c b/drivers/staging/usbip/vhci_sysfs.c index d9736f9..7b6e4a9 100644 --- a/drivers/staging/usbip/vhci_sysfs.c +++ b/drivers/staging/usbip/vhci_sysfs.c @@ -135,7 +135,7 @@ static DEVICE_ATTR(detach, S_IWUSR, NULL, store_detach); static int valid_args(__u32 rhport, enum usb_device_speed speed) { /* check rhport */ - if ((rhport < 0) || (rhport >= VHCI_NPORTS)) { + if (rhport >= VHCI_NPORTS) { pr_err("port %u\n", rhport); return -EINVAL; }