From: Minje Ahn <minje.ahn@samsung.com>
Date: Thu, 6 Feb 2020 05:39:30 +0000 (+0900)
Subject: Improve error type conversion function
X-Git-Tag: submit/tizen/20200206.031941^0
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=988da7cf194ebc987f2f45cf7592688dba28a4a0;p=platform%2Fcore%2Fapi%2Fthumbnail-util.git

Improve error type conversion function

Change-Id: Id75dbb50f97731b619ba2944027c01e42584cdef
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
---

diff --git a/src/thumbnail_util.c b/src/thumbnail_util.c
index aff6477..676b4ad 100644
--- a/src/thumbnail_util.c
+++ b/src/thumbnail_util.c
@@ -52,33 +52,23 @@ int __thumbnail_util_replace_path(const char *path, char *replace_path)
 	return THUMBNAIL_UTIL_ERROR_NONE;
 }
 
-int __thumbnail_util_error_capi(int content_error)
+int __thumbnail_util_error_capi(int internal_error)
 {
-	/*Error None*/
-	if (content_error == MS_MEDIA_ERR_NONE)
+	switch (internal_error) {
+	case MS_MEDIA_ERR_NONE:
 		return THUMBNAIL_UTIL_ERROR_NONE;
-
-	/* Internal operation error*/
-	else if (content_error == MS_MEDIA_ERR_INVALID_PARAMETER)
+	case MS_MEDIA_ERR_INVALID_PARAMETER:
 		return THUMBNAIL_UTIL_ERROR_INVALID_PARAMETER;
-
-	else if (content_error == MS_MEDIA_ERR_OUT_OF_MEMORY)
+	case MS_MEDIA_ERR_OUT_OF_MEMORY:
 		return THUMBNAIL_UTIL_ERROR_OUT_OF_MEMORY;
-
-	/* IPC operation error*/
-	else if (content_error == MS_MEDIA_ERR_IPC)
-		return THUMBNAIL_UTIL_ERROR_INVALID_OPERATION;
-
-	/* MEDIA SERVER error*/
-	else if (content_error == MS_MEDIA_ERR_PERMISSION_DENIED)
+	case MS_MEDIA_ERR_PERMISSION_DENIED:
 		return THUMBNAIL_UTIL_ERROR_PERMISSION_DENIED;
-
-	/* Thumbnail error*/
-	else if ((content_error == MS_MEDIA_ERR_THUMB_TOO_BIG) || (content_error == MS_MEDIA_ERR_THUMB_UNSUPPORTED))
-			return THUMBNAIL_UTIL_ERROR_UNSUPPORTED_CONTENT;
-
-	/*ETC*/
-	return THUMBNAIL_UTIL_ERROR_INVALID_OPERATION;
+	case MS_MEDIA_ERR_THUMB_TOO_BIG:
+	case MS_MEDIA_ERR_THUMB_UNSUPPORTED:
+		return THUMBNAIL_UTIL_ERROR_UNSUPPORTED_CONTENT;
+	default:
+		return THUMBNAIL_UTIL_ERROR_INVALID_OPERATION;
+	}
 }
 
 void __thumbnail_util_convert_itoa(int request_id, char **req_str)