From: Bernd Schubert Date: Thu, 27 Sep 2012 01:24:57 +0000 (-0400) Subject: ext4: always set i_op in ext4_mknod() X-Git-Tag: v3.2.32~81 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9881fcc8b68753201ab8f84041ec70beac6df2f6;p=profile%2Fivi%2Fkernel-adaptation-intel-automotive.git ext4: always set i_op in ext4_mknod() commit 6a08f447facb4f9e29fcc30fb68060bb5a0d21c2 upstream. ext4_special_inode_operations have their own ifdef CONFIG_EXT4_FS_XATTR to mask those methods. And ext4_iget also always sets it, so there is an inconsistency. Signed-off-by: Bernd Schubert Signed-off-by: "Theodore Ts'o" Signed-off-by: Ben Hutchings --- diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index 4dd0890..88f97e5 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c @@ -1801,9 +1801,7 @@ retry: err = PTR_ERR(inode); if (!IS_ERR(inode)) { init_special_inode(inode, inode->i_mode, rdev); -#ifdef CONFIG_EXT4_FS_XATTR inode->i_op = &ext4_special_inode_operations; -#endif err = ext4_add_nondir(handle, dentry, inode); } ext4_journal_stop(handle);