From: SeungWon Lee <lsw2000.lee@samsung.com>
Date: Thu, 18 Apr 2013 10:52:28 +0000 (+0900)
Subject: Fix memory leak issue. (Checked with valgrind)
X-Git-Tag: accepted/tizen_2.1/20130425.034849~38^2~2^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=98790391ac3480d7e297a78b149610406ec4265e;p=platform%2Fframework%2Fnative%2Fappfw.git

Fix memory leak issue. (Checked with valgrind)

Change-Id: I3a3930fff284e5faa3dc9d07e496f02569497ce0
Signed-off-by: SeungWon Lee <lsw2000.lee@samsung.com>
---

diff --git a/src/app/FApp_AppSettingImpl.cpp b/src/app/FApp_AppSettingImpl.cpp
index 4649cc2..2b09b5d 100644
--- a/src/app/FApp_AppSettingImpl.cpp
+++ b/src/app/FApp_AppSettingImpl.cpp
@@ -165,11 +165,10 @@ _AppSettingImpl::_MutiInstanceManager::GetInstanceByAppId(const AppId& appId)
 	SysTryReturn(NID_APP, pPkgMgrImpl != null, null, E_SYSTEM,
 				 "[%s] A system error has been occurred. failed to get _PackageMaangerImpl.", GetErrorMessage(E_SYSTEM));
 
-	PackageInfo* pPackageInfo = null;
-	pPackageInfo = pPkgMgrImpl->GetPackageInfoN(packageId);	// !E_SUCCESS for DB fail and query fail
+	std::unique_ptr<PackageInfo> pPackageInfo(pPkgMgrImpl->GetPackageInfoN(packageId));	// !E_SUCCESS for DB fail and query fail
 	SysTryReturn(NID_APP, pPackageInfo != null, null, E_APP_NOT_INSTALLED, "[%s] Propagating.", GetErrorMessage(E_APP_NOT_INSTALLED));
 
-	const _PackageInfoImpl* pPkgInfoImpl = _PackageInfoImpl::GetInstance(pPackageInfo);
+	const _PackageInfoImpl* pPkgInfoImpl = _PackageInfoImpl::GetInstance(pPackageInfo.get());
 	SysTryReturn(NID_APP, pPkgInfoImpl != null, null, E_SYSTEM,
 				 "[%s] A system error has been occurred. failed to get _PackageInfoImpl.", GetErrorMessage(E_SYSTEM));
 
@@ -200,7 +199,6 @@ _AppSettingImpl::_MutiInstanceManager::GetInstanceByAppId(const AppId& appId)
 
 CATCH:
 	delete pAppSettingInstance;
-	delete pPackageInfo;
 	return null;
 }