From: Ilho Kim <ilho159.kim@samsung.com>
Date: Wed, 23 Sep 2020 06:43:24 +0000 (+0900)
Subject: Fix memory leak
X-Git-Tag: accepted/tizen/unified/20201029.124936~4
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=98407c34fc277bb15238f335c349fcf4e7bc0f38;p=platform%2Fcore%2Fappfw%2Fapp-installers.git

Fix memory leak

The memory allocated by getPublicKeyDER should be freed

Change-Id: I511d5cf0cb03c7f4656b362ceec3cebb75d4ff1a
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
---

diff --git a/src/common/certificate_validation.cc b/src/common/certificate_validation.cc
index 216d1d3..f5dd03f 100644
--- a/src/common/certificate_validation.cc
+++ b/src/common/certificate_validation.cc
@@ -63,12 +63,14 @@ static bool SetAuthorCertificate(const ValidationCore::SignatureData& data,
     LOG(ERROR) << "No certificates in certificate list";
     return false;
   }
-  unsigned char* public_key;
+  unsigned char* public_key = nullptr;
   size_t len;
   (*it)->getPublicKeyDER(&public_key, &len);
   std::string author_id =
       ci::EncodeBase64(public_key, len);
   cert_info->author_id.set(author_id);
+  free(public_key);
+
   return SetCertificate(data,
       &cert_info->auth_cert,
       &cert_info->auth_im_cert,