From: ulan <ulan@chromium.org>
Date: Wed, 29 Apr 2015 08:36:05 +0000 (-0700)
Subject: Add comment to justify AllowDeferredHandleDereference in WeakCell factory.
X-Git-Tag: upstream/4.7.83~2917
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=98390a07a5490501180e950ec928c91052129cd5;p=platform%2Fupstream%2Fv8.git

Add comment to justify AllowDeferredHandleDereference in WeakCell factory.

BUG=

Review URL: https://codereview.chromium.org/1110373002

Cr-Commit-Position: refs/heads/master@{#28123}
---

diff --git a/src/factory.cc b/src/factory.cc
index d2a8d79..133f74d 100644
--- a/src/factory.cc
+++ b/src/factory.cc
@@ -942,6 +942,8 @@ Handle<PropertyCell> Factory::NewPropertyCell() {
 
 
 Handle<WeakCell> Factory::NewWeakCell(Handle<HeapObject> value) {
+  // It is safe to dereference the value because we are embedding it
+  // in cell and not inspecting its fields.
   AllowDeferredHandleDereference convert_to_cell;
   CALL_HEAP_FUNCTION(isolate(), isolate()->heap()->AllocateWeakCell(*value),
                      WeakCell);