From: Dan Winship <danw@gnome.org>
Date: Tue, 28 Oct 2014 19:08:43 +0000 (-0400)
Subject: GTlsCertificate: fix loading of bad certificate chains
X-Git-Tag: 2.43.1~19
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=982d0e11d702ff49f69cb90cb65dd71ebd3df54d;p=platform%2Fupstream%2Fglib.git

GTlsCertificate: fix loading of bad certificate chains

g_tls_certificate_new_from_file() was only loading the complete chain
if it was fully valid, but we only meant to be validating that it
formed an actual chain (since the caller may be planning to ignore
other errors).

https://bugzilla.gnome.org/show_bug.cgi?id=729739
---

diff --git a/gio/gtlscertificate.c b/gio/gtlscertificate.c
index 9e3faf26f..81e072f57 100644
--- a/gio/gtlscertificate.c
+++ b/gio/gtlscertificate.c
@@ -387,14 +387,14 @@ create_certificate_chain_from_list (GSList       *pem_list,
       pem = g_slist_next (pem);
     }
 
-  /* Verify the certificate chain and return NULL if it doesn't
-   * verify. */
+  /* Verify that the certificates form a chain. (We don't care at this
+   * point if there are other problems with it.)
+   */
   flags = g_tls_certificate_verify (cert, NULL, root);
-  if (flags)
+  if (flags & G_TLS_CERTIFICATE_UNKNOWN_CA)
     {
-      /* Couldn't verify the certificate chain, so unref it. */
-      g_object_unref (cert);
-      cert = NULL;
+      /* It wasn't a chain, it's just a bunch of unrelated certs. */
+      g_clear_object (&cert);
     }
 
   return cert;