From: Lin Ming Date: Tue, 20 Sep 2011 19:45:07 +0000 (-0400) Subject: netconsole: switch init_netconsole() to late_initcall X-Git-Tag: v3.1-rc7~2^2~5 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=97c7de055713afddf4218f19c896b5185555da15;p=platform%2Fupstream%2Fkernel-adaptation-pc.git netconsole: switch init_netconsole() to late_initcall Commit 88491d8(drivers/net: Kconfig & Makefile cleanup) causes a regression that netconsole does not work if netconsole and network device driver are build into kernel, because netconsole is linked before network device driver. Andrew Morton suggested to fix this with initcall ordering. Fixes it by switching init_netconsole() to late_initcall. Signed-off-by: Lin Ming Signed-off-by: David S. Miller --- diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index dfc8272..ed2a397 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c @@ -799,5 +799,11 @@ static void __exit cleanup_netconsole(void) } } -module_init(init_netconsole); +/* + * Use late_initcall to ensure netconsole is + * initialized after network device driver if built-in. + * + * late_initcall() and module_init() are identical if built as module. + */ +late_initcall(init_netconsole); module_exit(cleanup_netconsole);