From: Xiongfeng Wang Date: Fri, 12 Jan 2018 07:56:05 +0000 (+0800) Subject: IB/cma: use strlcpy() instead of strncpy() X-Git-Tag: v4.19~1637^2~117 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=979a459c8347a797fd03717a3f12289c91617982;p=platform%2Fkernel%2Flinux-rpi.git IB/cma: use strlcpy() instead of strncpy() gcc-8 reports drivers/infiniband/core/cma_configfs.c: In function 'make_cma_dev': ./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified bound 64 equals destination size [-Wstringop-truncation] We need to use strlcpy() to make sure the string is nul-terminated. Signed-off-by: Xiongfeng Wang Reviewed-by: Leon Romanovsky Signed-off-by: Jason Gunthorpe --- diff --git a/drivers/infiniband/core/cma_configfs.c b/drivers/infiniband/core/cma_configfs.c index 31dfee0..eee38b4 100644 --- a/drivers/infiniband/core/cma_configfs.c +++ b/drivers/infiniband/core/cma_configfs.c @@ -295,7 +295,7 @@ static struct config_group *make_cma_dev(struct config_group *group, goto fail; } - strncpy(cma_dev_group->name, name, sizeof(cma_dev_group->name)); + strlcpy(cma_dev_group->name, name, sizeof(cma_dev_group->name)); config_group_init_type_name(&cma_dev_group->ports_group, "ports", &cma_ports_group_type);