From: Heiko Carstens <heiko.carstens@de.ibm.com>
Date: Mon, 14 Oct 2013 12:26:08 +0000 (+0200)
Subject: s390/vmlogrdr: fix array access in vmlogrdr_open()
X-Git-Tag: upstream/snapshot3+hdmi~4113^2~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9784bd4f1a6ea736ad9bf241f5a965e0a2913a5e;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git

s390/vmlogrdr: fix array access in vmlogrdr_open()

Fix check within vmlogrdr_open() if the minor address is not larger
than the number of array elements.

Found with "smatch":

drivers/s390/char/vmlogrdr.c:318 vmlogrdr_open() warn:
  buffer overflow 'sys_ser' 3 <= 3

Acked-by: Stefan Weinhuber <wein@de.ibm.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
---

diff --git a/drivers/s390/char/vmlogrdr.c b/drivers/s390/char/vmlogrdr.c
index 9b3a24e..cf31d33 100644
--- a/drivers/s390/char/vmlogrdr.c
+++ b/drivers/s390/char/vmlogrdr.c
@@ -313,7 +313,7 @@ static int vmlogrdr_open (struct inode *inode, struct file *filp)
 	int ret;
 
 	dev_num = iminor(inode);
-	if (dev_num > MAXMINOR)
+	if (dev_num >= MAXMINOR)
 		return -ENODEV;
 	logptr = &sys_ser[dev_num];