From: Pan Bian <bianpan2016@163.com>
Date: Thu, 21 Jan 2021 07:22:02 +0000 (-0800)
Subject: lightnvm: fix memory leak when submit fails
X-Git-Tag: accepted/tizen/unified/20230118.172025~7944^2~12
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=97784481757fba7570121a70dd37ca74a29f50a8;p=platform%2Fkernel%2Flinux-rpi.git

lightnvm: fix memory leak when submit fails

The allocated page is not released if error occurs in
nvm_submit_io_sync_raw(). __free_page() is moved ealier to avoid
possible memory leak issue.

Fixes: aff3fb18f957 ("lightnvm: move bad block and chunk state logic to core")
Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---

diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c
index c1bcac7..28ddcaa 100644
--- a/drivers/lightnvm/core.c
+++ b/drivers/lightnvm/core.c
@@ -844,11 +844,10 @@ static int nvm_bb_chunk_sense(struct nvm_dev *dev, struct ppa_addr ppa)
 	rqd.ppa_addr = generic_to_dev_addr(dev, ppa);
 
 	ret = nvm_submit_io_sync_raw(dev, &rqd);
+	__free_page(page);
 	if (ret)
 		return ret;
 
-	__free_page(page);
-
 	return rqd.error;
 }