From: Arun Ramadoss Date: Tue, 13 Dec 2022 10:14:40 +0000 (+0530) Subject: net: dsa: microchip: remove IRQF_TRIGGER_FALLING in request_threaded_irq X-Git-Tag: v6.1.8~1038 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=96ea05df9ed54895f8e459029b50066c0dc18086;p=platform%2Fkernel%2Flinux-starfive.git net: dsa: microchip: remove IRQF_TRIGGER_FALLING in request_threaded_irq [ Upstream commit 62e027fb0e5293d95e8d36655757ef4687c8795d ] KSZ swithes used interrupts for detecting the phy link up and down. During registering the interrupt handler, it used IRQF_TRIGGER_FALLING flag. But this flag has to be retrieved from device tree instead of hard coding in the driver, so removing the flag. Fixes: ff319a644829 ("net: dsa: microchip: move interrupt handling logic from lan937x to ksz_common") Reported-by: Christian Eggers Signed-off-by: Arun Ramadoss Link: https://lore.kernel.org/r/20221213101440.24667-1-arun.ramadoss@microchip.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c index d612181..c68f48c 100644 --- a/drivers/net/dsa/microchip/ksz_common.c +++ b/drivers/net/dsa/microchip/ksz_common.c @@ -1883,8 +1883,7 @@ static int ksz_irq_common_setup(struct ksz_device *dev, struct ksz_irq *kirq) irq_create_mapping(kirq->domain, n); ret = request_threaded_irq(kirq->irq_num, NULL, ksz_irq_thread_fn, - IRQF_ONESHOT | IRQF_TRIGGER_FALLING, - kirq->name, kirq); + IRQF_ONESHOT, kirq->name, kirq); if (ret) goto out;