From: jkummerow@chromium.org Date: Fri, 21 Jun 2013 16:19:51 +0000 (+0000) Subject: Use kPointerSize to compute the size of StubCache::Entry for X64 X-Git-Tag: upstream/4.7.83~13727 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=96e818136cc0616527b9feb68add8cb6f9173325;p=platform%2Fupstream%2Fv8.git Use kPointerSize to compute the size of StubCache::Entry for X64 R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/17552004 Patch from Haitao Feng . git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15272 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- diff --git a/src/x64/stub-cache-x64.cc b/src/x64/stub-cache-x64.cc index 25fb710..9dddd79 100644 --- a/src/x64/stub-cache-x64.cc +++ b/src/x64/stub-cache-x64.cc @@ -53,7 +53,7 @@ static void ProbeTable(Isolate* isolate, ASSERT(kPointerSizeLog2 == kHeapObjectTagSize + 1); ScaleFactor scale_factor = times_2; - ASSERT_EQ(24, sizeof(StubCache::Entry)); + ASSERT_EQ(3 * kPointerSize, sizeof(StubCache::Entry)); // The offset register holds the entry offset times four (due to masking // and shifting optimizations). ExternalReference key_offset(isolate->stub_cache()->key_reference(table)); @@ -171,8 +171,8 @@ void StubCache::GenerateProbe(MacroAssembler* masm, USE(extra2); // The register extra2 is not used on the X64 platform. USE(extra3); // The register extra2 is not used on the X64 platform. // Make sure that code is valid. The multiplying code relies on the - // entry size being 24. - ASSERT(sizeof(Entry) == 24); + // entry size being 3 * kPointerSize. + ASSERT(sizeof(Entry) == 3 * kPointerSize); // Make sure the flags do not name a specific type. ASSERT(Code::ExtractTypeFromFlags(flags) == 0);