From: Al Viro <viro@zeniv.linux.org.uk>
Date: Sat, 30 Mar 2013 17:15:27 +0000 (-0400)
Subject: isp1362-hcd: don't reimplement proc_create_data()
X-Git-Tag: v3.12-rc1~937^2~160
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=96e7d9158f5ae91accb9c81cca14bcd0c996c0cc;p=kernel%2Fkernel-generic.git

isp1362-hcd: don't reimplement proc_create_data()

... especially in a racy way

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---

diff --git a/drivers/usb/host/isp1362-hcd.c b/drivers/usb/host/isp1362-hcd.c
index 974480c..9137caa 100644
--- a/drivers/usb/host/isp1362-hcd.c
+++ b/drivers/usb/host/isp1362-hcd.c
@@ -2192,14 +2192,11 @@ static void create_debug_file(struct isp1362_hcd *isp1362_hcd)
 {
 	struct proc_dir_entry *pde;
 
-	pde = create_proc_entry(proc_filename, 0, NULL);
+	pde = proc_create_data(proc_filename, 0, NULL, &proc_ops, isp1362_hcd);
 	if (pde == NULL) {
 		pr_warning("%s: Failed to create debug file '%s'\n", __func__, proc_filename);
 		return;
 	}
-
-	pde->proc_fops = &proc_ops;
-	pde->data = isp1362_hcd;
 	isp1362_hcd->pde = pde;
 }