From: Tom Tromey Date: Tue, 4 May 2021 21:26:58 +0000 (-0600) Subject: libcc1: avoid extra string copies X-Git-Tag: upstream/12.2.0~8224 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=96deddca2e535d09db1d244a96a1efc20e24b673;p=platform%2Fupstream%2Fgcc.git libcc1: avoid extra string copies PR c/94669 points out that a couple of spots in libcc1 take a std::string where a reference would do. This changes these spots to take a const char *, to reduce the number of copies. libcc1 PR c/94669 * compiler.hh (compiler_driver_filename): Take const char *. (compiler_triplet_regexp): Likewise. --- diff --git a/libcc1/compiler.hh b/libcc1/compiler.hh index 638f7c0..d10d409 100644 --- a/libcc1/compiler.hh +++ b/libcc1/compiler.hh @@ -58,7 +58,7 @@ namespace cc1_plugin char *find (const char *base, std::string &compiler) const override; - compiler_triplet_regexp (bool v, std::string triplet_regexp) + compiler_triplet_regexp (bool v, const char *triplet_regexp) : compiler (v), triplet_regexp_ (triplet_regexp) { } @@ -72,7 +72,7 @@ namespace cc1_plugin public: char *find (const char *base, std::string &compiler) const override; - compiler_driver_filename (bool v, std::string driver_filename) + compiler_driver_filename (bool v, const char *driver_filename) : compiler (v), driver_filename_ (driver_filename) { }