From: Doug Kwan <dougkwan@google.com>
Date: Thu, 4 Jun 2009 01:31:01 +0000 (+0000)
Subject: 2009-06-03  Doug Kwan  <dougkwan@google.com>
X-Git-Tag: cgen-1_1-branchpoint~134
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=96d493066dbfe6581b2647c36c351fac201da48b;p=external%2Fbinutils.git

2009-06-03  Doug Kwan  <dougkwan@google.com>

	* arm.cc (utils::sign_extend): Reverse test in gold_assert.
	(utils::has_overflow): Same.
---

diff --git a/gold/ChangeLog b/gold/ChangeLog
index 7408ac6..8f42e6a 100644
--- a/gold/ChangeLog
+++ b/gold/ChangeLog
@@ -1,3 +1,8 @@
+2009-06-03  Doug Kwan  <dougkwan@google.com>
+
+	* arm.cc (utils::sign_extend): Reverse test in gold_assert.
+	(utils::has_overflow): Same.
+
 2009-06-03  Ian Lance Taylor  <iant@google.com>
 
 	* layout.cc (Layout::section_name_mapping): New array, replacing
diff --git a/gold/arm.cc b/gold/arm.cc
index 5165a52..76538de 100644
--- a/gold/arm.cc
+++ b/gold/arm.cc
@@ -97,7 +97,7 @@ namespace utils
   static inline int32_t
   sign_extend(uint32_t bits)
   {
-    gold_assert(no_bits < 1 || no_bits > 32);
+    gold_assert(no_bits >= 0 && no_bits <= 32);
     if (no_bits == 32)
       return static_cast<int32_t>(bits);
     uint32_t mask = (~((uint32_t) 0)) >> (32 - no_bits);
@@ -112,7 +112,7 @@ namespace utils
   static inline bool
   has_overflow(uint32_t bits)
   {
-    gold_assert(no_bits < 1 || no_bits > 32);
+    gold_assert(no_bits >= 0 && no_bits <= 32);
     if (no_bits == 32)
       return false;
     int32_t max = (1 << (no_bits - 1)) - 1;