From: Jan Kara Date: Wed, 14 Mar 2012 02:24:54 +0000 (-0400) Subject: jbd2: fix BH_JWrite setting in checkpointing code X-Git-Tag: v3.4-rc1~75^2~23 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=96c866782b5e0cbdcd8e4d921d0a893278430830;p=profile%2Fivi%2Fkernel-adaptation-intel-automotive.git jbd2: fix BH_JWrite setting in checkpointing code BH_JWrite bit should be set when buffer is written to the journal. So checkpointing shouldn't set this bit when writing out buffer. This didn't cause any observable bug since BH_JWrite bit is used only for debugging purposes but it's good to have this consistent. Signed-off-by: Jan Kara Signed-off-by: "Theodore Ts'o" --- diff --git a/fs/jbd2/checkpoint.c b/fs/jbd2/checkpoint.c index 7f7ee5b..546c3b3 100644 --- a/fs/jbd2/checkpoint.c +++ b/fs/jbd2/checkpoint.c @@ -266,7 +266,6 @@ __flush_batch(journal_t *journal, int *batch_count) for (i = 0; i < *batch_count; i++) { struct buffer_head *bh = journal->j_chkpt_bhs[i]; - clear_buffer_jwrite(bh); BUFFER_TRACE(bh, "brelse"); __brelse(bh); } @@ -340,7 +339,6 @@ static int __process_buffer(journal_t *journal, struct journal_head *jh, BUFFER_TRACE(bh, "queue"); get_bh(bh); J_ASSERT_BH(bh, !buffer_jwrite(bh)); - set_buffer_jwrite(bh); journal->j_chkpt_bhs[*batch_count] = bh; __buffer_relink_io(jh); jbd_unlock_bh_state(bh);