From: Danylo Piliaiev <dpiliaiev@igalia.com>
Date: Fri, 6 Oct 2023 14:46:59 +0000 (+0200)
Subject: tu: Fix stale tu_render_pass_attachment::store_stencil with dyn rendering
X-Git-Tag: upstream/23.3.3~1080
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=964a27aa39f326edf070b0dea91c614af0970ed7;p=platform%2Fupstream%2Fmesa.git

tu: Fix stale tu_render_pass_attachment::store_stencil with dyn rendering

Attachment initialization helpers expect zeroed memory by default.

Fixes a hang when running Subnautica with TU_DEBUG="gmem".
See: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8702#note_1932003

Fixes: ed125e6cca188275631641784fcf3ddcbcfef193
("tu: Initial support for dynamic rendering")

Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25592>
---

diff --git a/src/freedreno/vulkan/tu_pass.cc b/src/freedreno/vulkan/tu_pass.cc
index 299495e..b304ef4 100644
--- a/src/freedreno/vulkan/tu_pass.cc
+++ b/src/freedreno/vulkan/tu_pass.cc
@@ -1063,6 +1063,7 @@ static void
 tu_setup_dynamic_attachment(struct tu_render_pass_attachment *att,
                             struct tu_image_view *view)
 {
+   *att = {};
    att->format = view->vk.format;
    att->samples = (VkSampleCountFlagBits) view->image->layout->nr_samples;