From: SooChan Lim <sc1.lim@samsung.com>
Date: Tue, 22 Jun 2021 05:47:21 +0000 (+0900)
Subject: tizen-hwc: remove the commit_feedback request
X-Git-Tag: submit/tizen/20210625.061033~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=961b20328a9ca681fbbb4bc61c83c8bb06f4524e;p=platform%2Fcore%2Fuifw%2Fwayland-extension.git

tizen-hwc: remove the commit_feedback request

This request generates the tizen_hwc_commit_feedback function.
This name of the function is the same as the interface name of
tizen_hwc_commit_feedback. It makes the build warning because the
function name and the resource type name are the same.

use create_commit_feedback instead of commit_feedback

Change-Id: I948de82c808801fb97350e1a7e1b86e5834d79d8
---

diff --git a/protocol/tizen/tizen-hwc.xml b/protocol/tizen/tizen-hwc.xml
index bd143eb..9ecf457 100644
--- a/protocol/tizen/tizen-hwc.xml
+++ b/protocol/tizen/tizen-hwc.xml
@@ -9,19 +9,6 @@
       </description>
     </request>
 
-    <request name="commit_feedback">
-      <description summary="">
-        Request a notification when a display server requests a hwc_commit to the device(Hardware).
-        This request is a tizen-specific one. The client wants to know when a display server
-        executes the requests of the wl_surface to the device. In this case, the display server
-        has to send committed event to the client on tizen_commit_feedback interface after it
-        executed the hwc_commit to the device.
-      </description>
-      <arg name="surface" type="object" interface="wl_surface" summary="target surface object"/>
-      <arg name="id" type="new_id" interface="tizen_hwc_commit_feedback" summary="new feedback object"/>
-      <arg name="serial" type="uint" summary="serial number of request"/>
-    </request>
-
     <request name="create_commit_feedback">
       <description summary="">
         Request a notification when a display server requests a hwc_commit to the device(Hardware).
diff --git a/unittests/tc-tizen-hwc.cpp b/unittests/tc-tizen-hwc.cpp
index bb0a1b0..f16a026 100644
--- a/unittests/tc-tizen-hwc.cpp
+++ b/unittests/tc-tizen-hwc.cpp
@@ -101,7 +101,7 @@ private:
 };
 
 static void
-compositor_tizen_hwc_cb_commit_feedback(struct wl_client *client,
+compositor_tizen_hwc_cb_create_commit_feedback(struct wl_client *client,
 							struct wl_resource *tizen_hwc_resource,
 							struct wl_resource *surface_resource,
 							uint32_t id,
@@ -131,7 +131,7 @@ compositor_tizen_hwc_cb_destroy(struct wl_client *client, struct wl_resource *ti
 
 static const struct tizen_hwc_interface compositor_tizen_hwc_implementation = {
 	.destroy = compositor_tizen_hwc_cb_destroy,
-	.commit_feedback = compositor_tizen_hwc_cb_commit_feedback
+	.create_commit_feedback = compositor_tizen_hwc_cb_create_commit_feedback
 };
 
 static void
@@ -226,7 +226,7 @@ TEST_F(TizenHwcTest, TizenHwcCommit)
 	struct wl_surface *surface_res = wl_compositor_create_surface(client.GetGlobalResWlCompositor());
 
 	struct tizen_hwc *tizen_hwc = client.GetGlobalResTizenHwc();
-	struct tizen_hwc_commit_feedback *hwc_commit_feedback = tizen_hwc_commit_feedback(tizen_hwc, surface_res, 1);
+	struct tizen_hwc_commit_feedback *hwc_commit_feedback = tizen_hwc_create_commit_feedback(tizen_hwc, surface_res, 1);
 	tizen_hwc_commit_feedback_add_listener(hwc_commit_feedback,
 									&hwc_commit_feedback_cb_listener,
 									&client);