From: Tobin C. Harding Date: Thu, 27 Apr 2017 01:25:17 +0000 (+1000) Subject: staging: ks7010: clean memory allocation X-Git-Tag: v5.15~11366^2~89 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=95e72fba95fd1d9b9ef3ab080aafe1076f42a10a;p=platform%2Fkernel%2Flinux-starfive.git staging: ks7010: clean memory allocation Memory allocation code contains unneeded debug statements, failed kmalloc() calls typically do not require a debug message. Introduction of a local 'size' variable allows kmalloc() call to be marginally cleaner, still uses magic numbers but these require a more substantial fix. Moving the magic numbers onto a single line opens the way for further refactoring. Clean memory allocation code, remove debug statements. Signed-off-by: Tobin C. Harding Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c index 8755bd9..7e9855f 100644 --- a/drivers/staging/ks7010/ks_hostif.c +++ b/drivers/staging/ks7010/ks_hostif.c @@ -1135,12 +1135,9 @@ int hostif_data_request(struct ks_wlan_private *priv, struct sk_buff *skb) netif_stop_queue(priv->net_dev); } - DPRINTK(4, "skb_buff length=%d\n", skb_len); - pp = kmalloc(hif_align_size(sizeof(*pp) + 6 + skb_len + 8), - KS_WLAN_MEM_FLAG); - + size = sizeof(*pp) + 6 + skb_len + 8; + pp = kmalloc(hif_align_size(size), KS_WLAN_MEM_FLAG); if (!pp) { - DPRINTK(3, "allocate memory failed..\n"); ret = -ENOMEM; goto err_kfree_skb; }