From: Michał Mirosław Date: Mon, 17 Dec 2018 19:28:15 +0000 (+0100) Subject: power: supply: bq25890: fix BAT_COMP field definition X-Git-Tag: v5.15~7304^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9580913966488dc78d8d2893c7427d0a84124e74;p=platform%2Fkernel%2Flinux-starfive.git power: supply: bq25890: fix BAT_COMP field definition According to datasheet, BAT_COMP field spans bits 5-7. The rest of the code seems to assume this already. Fixes: 4aeae9cb0dad ("power_supply: Add support for TI BQ25890 charger chip") Signed-off-by: Michał Mirosław Signed-off-by: Sebastian Reichel --- diff --git a/drivers/power/supply/bq25890_charger.c b/drivers/power/supply/bq25890_charger.c index 70b90db..3f6fb49 100644 --- a/drivers/power/supply/bq25890_charger.c +++ b/drivers/power/supply/bq25890_charger.c @@ -183,7 +183,7 @@ static const struct reg_field bq25890_reg_fields[] = { [F_CHG_TMR] = REG_FIELD(0x07, 1, 2), [F_JEITA_ISET] = REG_FIELD(0x07, 0, 0), /* REG08 */ - [F_BATCMP] = REG_FIELD(0x08, 6, 7), // 5-7 on BQ25896 + [F_BATCMP] = REG_FIELD(0x08, 5, 7), [F_VCLAMP] = REG_FIELD(0x08, 2, 4), [F_TREG] = REG_FIELD(0x08, 0, 1), /* REG09 */