From: Benjamin Kramer <benny.kra@googlemail.com>
Date: Tue, 17 Sep 2019 14:56:11 +0000 (+0000)
Subject: [clangd] Fix another TSAN issue
X-Git-Tag: llvmorg-11-init~9001
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=957a6c6bedfa87e5384703724c18ddeada9e189e;p=platform%2Fupstream%2Fllvm.git

[clangd] Fix another TSAN issue

llvm-svn: 372128
---

diff --git a/clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp b/clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp
index 5dbfca5..db05c70 100644
--- a/clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp
+++ b/clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp
@@ -769,12 +769,14 @@ TEST_F(TUSchedulerTests, CommandLineWarnings) {
   // We should not see warnings from command-line parsing.
   CDB.ExtraClangFlags = {"-Wsome-unknown-warning"};
 
+  // (!) 'Ready' must live longer than TUScheduler.
+  Notification Ready;
+
   TUScheduler S(CDB, /*AsyncThreadsCount=*/getDefaultAsyncThreadsCount(),
                 /*StorePreambleInMemory=*/true, /*ASTCallbacks=*/captureDiags(),
                 /*UpdateDebounce=*/std::chrono::steady_clock::duration::zero(),
                 ASTRetentionPolicy());
 
-  Notification Ready;
   std::vector<Diag> Diagnostics;
   updateWithDiags(S, testPath("foo.cpp"), "void test() {}",
                   WantDiagnostics::Yes, [&](std::vector<Diag> D) {