From: ruanjinjie Date: Wed, 9 Nov 2022 09:28:52 +0000 (+0800) Subject: NTB: EPF: fix possible memory leak in pci_vntb_probe() X-Git-Tag: v6.6.17~4401^2~8 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=956578e3d397e00d6254dc7b5194d28587f98518;p=platform%2Fkernel%2Flinux-rpi.git NTB: EPF: fix possible memory leak in pci_vntb_probe() As ntb_register_device() don't handle error of device_register(), if ntb_register_device() returns error in pci_vntb_probe(), name of kobject which is allocated in dev_set_name() called in device_add() is leaked. As comment of device_add() says, it should call put_device() to drop the reference count that was set in device_initialize() when it fails, so the name can be freed in kobject_cleanup(). Signed-off-by: ruanjinjie Signed-off-by: Jon Mason --- diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c index b7c7a8a..7730698 100644 --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c @@ -1285,6 +1285,7 @@ static int pci_vntb_probe(struct pci_dev *pdev, const struct pci_device_id *id) return 0; err_register_dev: + put_device(&ndev->ntb.dev); return -EINVAL; }