From: Grant Likely <grant.likely@secretlab.ca>
Date: Sat, 22 Mar 2008 03:41:05 +0000 (+1100)
Subject: [POWERPC] mpc5200: Fix null dereference if bestcomm fails to initialize
X-Git-Tag: v2.6.25-rc7~23^2~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9560aea4e9d17cb75113c6051e800222fd5c71a4;p=platform%2Fkernel%2Flinux-exynos.git

[POWERPC] mpc5200: Fix null dereference if bestcomm fails to initialize

If the bestcomm initialization fails, calls to the task allocate
function should fail gracefully instead of oopsing with a NULL deref.

Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Signed-off-by: Paul Mackerras <paulus@samba.org>
---

diff --git a/arch/powerpc/sysdev/bestcomm/bestcomm.c b/arch/powerpc/sysdev/bestcomm/bestcomm.c
index f589999..b18cab5 100644
--- a/arch/powerpc/sysdev/bestcomm/bestcomm.c
+++ b/arch/powerpc/sysdev/bestcomm/bestcomm.c
@@ -52,6 +52,10 @@ bcom_task_alloc(int bd_count, int bd_size, int priv_size)
 	int i, tasknum = -1;
 	struct bcom_task *tsk;
 
+	/* Don't try to do anything if bestcomm init failed */
+	if (!bcom_eng)
+		return NULL;
+
 	/* Get and reserve a task num */
 	spin_lock(&bcom_eng->lock);