From: Changyeon Lee Date: Fri, 31 Aug 2018 07:22:01 +0000 (+0900) Subject: e_mod_effect: use e_comp_client_override_add/del in show/hide effect X-Git-Tag: accepted/tizen/unified/20190905.060604~3 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9549bc2a512e12ac9f3c1ae529da275fb56203de;p=platform%2Fcore%2Fuifw%2Fe-mod-tizen-effect.git e_mod_effect: use e_comp_client_override_add/del in show/hide effect show/hide effect isn't needed that all hwc plane is unset. e_comp_client_override_add/del unset hwc plane if ec of hwc is locate to below ec. Change-Id: I2156e41926db993e89037ebb96bfe159be7457b4 --- diff --git a/src/e_mod_effect.c b/src/e_mod_effect.c index 25b5a94..c14bc91 100644 --- a/src/e_mod_effect.c +++ b/src/e_mod_effect.c @@ -921,11 +921,11 @@ _eff_cb_visible_done(void *data, Evas_Object *obj EINA_UNUSED, const char *sig E if (ec) { _eff_event_send(ec, EINA_FALSE, E_EFFECT_TYPE_SHOW); + e_comp_client_override_del(ec); _eff_unref(ec); } _eff_stack_update(); - e_comp_override_del(); } static Eina_Bool @@ -949,7 +949,7 @@ _eff_cb_visible(void *data, Evas_Object *obj, const char *signal) if (!_eff_ref(ec)) return EINA_FALSE; _eff_stack_update(); - e_comp_override_add(); + e_comp_client_override_add(ec); EFFINF("SET EXTRA_ANIMATING...", ec); ec->extra_animating = EINA_TRUE; @@ -985,6 +985,7 @@ _eff_cb_hidden_done(void *data, Evas_Object *obj, const char *sig, const char *s if (ec) { _eff_event_send(ec, EINA_FALSE, E_EFFECT_TYPE_HIDE); + e_comp_client_override_del(ec); if (_eff_unref(ec)) { if (_eff_client_get(ec)) @@ -994,8 +995,6 @@ _eff_cb_hidden_done(void *data, Evas_Object *obj, const char *sig, const char *s } } } - - e_comp_override_del(); } static Eina_Bool @@ -1039,7 +1038,7 @@ _eff_cb_hidden(void *data, Evas_Object *obj, const char *signal) if (!_eff_ref(ec)) return EINA_FALSE; - e_comp_override_add(); + e_comp_client_override_add(ec); // check if client was lowered below = evas_object_below_get(obj); @@ -1082,10 +1081,9 @@ _eff_cb_uniconify_done(void *data, Evas_Object *obj, const char *sig, const char if (ec) { _eff_event_send(ec, EINA_FALSE, E_EFFECT_TYPE_SHOW); + e_comp_client_override_del(ec); _eff_unref(ec); } - - e_comp_override_del(); } static Eina_Bool @@ -1161,7 +1159,7 @@ _eff_cb_uniconify(void *data, Evas_Object *obj, const char *signal) if (!_eff_ref(ec)) return EINA_FALSE; - e_comp_override_add(); + e_comp_client_override_add(ec); _eff_object_setup(ec, group); _eff_object_under_setup(ec); @@ -1194,14 +1192,13 @@ _eff_cb_iconify_done(void *data, Evas_Object *obj, const char *sig, const char * if (ec) { _eff_event_send(ec, EINA_FALSE, E_EFFECT_TYPE_HIDE); + e_comp_client_override_del(ec); if (_eff_unref(ec)) { if (_eff_client_get(ec)) evas_object_hide(ec->frame); } } - - e_comp_override_del(); } static Eina_Bool @@ -1237,7 +1234,7 @@ _eff_cb_iconify(void *data, Evas_Object *obj, const char *signal) if (!_eff_ref(ec)) return EINA_FALSE; - e_comp_override_add(); + e_comp_client_override_add(ec); _eff_object_setup(ec, group); _eff_object_under_setup(ec); @@ -1268,11 +1265,11 @@ _eff_cb_restack_show_done(void *data, Evas_Object *obj, const char *sig, const c if (ec) { _eff_event_send(ec, EINA_FALSE, E_EFFECT_TYPE_RESTACK_SHOW); + e_comp_client_override_del(ec); _eff_unref(ec); } _eff_stack_update(); - e_comp_override_del(); } static void @@ -1282,6 +1279,7 @@ _eff_cb_restack_hide_done(void *data, Evas_Object *obj, const char *sig, const c if (ec) { + e_comp_client_override_del(ec); if (_eff_unref(ec)) { if (_eff_client_get(ec)) @@ -1295,7 +1293,6 @@ _eff_cb_restack_hide_done(void *data, Evas_Object *obj, const char *sig, const c } _eff_stack_update(); - e_comp_override_del(); } static void @@ -1331,10 +1328,9 @@ _eff_cb_restack_finish_done(void *data, Evas_Object *obj, const char *sig, const efc->reverse_ec = NULL; } + e_comp_client_override_del(ec); _eff_unref(ec); } - - e_comp_override_del(); } static Eina_Bool @@ -1401,7 +1397,7 @@ _eff_cb_restack(void *data, Evas_Object *obj, const char *signal) EFFINF("SET EXTRA_ANIMATING...", ec); ec->extra_animating = EINA_TRUE; - e_comp_override_add(); + e_comp_client_override_add(ec); _eff_object_setup(ec, group); _eff_object_under_setup(ec); @@ -1452,7 +1448,7 @@ _eff_cb_restack(void *data, Evas_Object *obj, const char *signal) } } - e_comp_override_add(); + e_comp_client_override_add(ec); _eff_object_layer_up(ec); @@ -1479,7 +1475,7 @@ _eff_cb_restack(void *data, Evas_Object *obj, const char *signal) { if (!_eff_ref(ec)) return EINA_FALSE; - e_comp_override_add(); + e_comp_client_override_add(ec); _eff_object_setup(ec, group); _eff_object_under_setup(ec);