From: Tom St Denis Date: Fri, 26 Jan 2018 14:32:29 +0000 (-0500) Subject: drm/ttm: Fix 'buf' pointer update in ttm_bo_vm_access_kmap() (v2) X-Git-Tag: v4.19~1610^2~1^2~7 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=95244db2d3f743f37e69446a2807dd1a42750542;p=platform%2Fkernel%2Flinux-rpi3.git drm/ttm: Fix 'buf' pointer update in ttm_bo_vm_access_kmap() (v2) The buf pointer was not being incremented inside the loop meaning the same block of data would be read or written repeatedly. (v2) Change 'buf' pointer to uint8_t* type Cc: stable@vger.kernel.org Fixes: 09ac4fcb3f25 ("drm/ttm: Implement vm_operations_struct.access v2") Signed-off-by: Tom St Denis Reviewed-by: Christian König Signed-off-by: Alex Deucher --- diff --git a/drivers/gpu/drm/ttm/ttm_bo_vm.c b/drivers/gpu/drm/ttm/ttm_bo_vm.c index 08a3c32..60fcef1 100644 --- a/drivers/gpu/drm/ttm/ttm_bo_vm.c +++ b/drivers/gpu/drm/ttm/ttm_bo_vm.c @@ -316,7 +316,7 @@ static void ttm_bo_vm_close(struct vm_area_struct *vma) static int ttm_bo_vm_access_kmap(struct ttm_buffer_object *bo, unsigned long offset, - void *buf, int len, int write) + uint8_t *buf, int len, int write) { unsigned long page = offset >> PAGE_SHIFT; unsigned long bytes_left = len; @@ -345,6 +345,7 @@ static int ttm_bo_vm_access_kmap(struct ttm_buffer_object *bo, ttm_bo_kunmap(&map); page++; + buf += bytes; bytes_left -= bytes; offset = 0; } while (bytes_left);