From: Christophe JAILLET Date: Sun, 9 Jan 2022 12:34:18 +0000 (+0100) Subject: i2c: amd-mp2: Remove useless DMA-32 fallback configuration X-Git-Tag: v6.6.17~7892^2~56 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=951285e59e8ac1d056780b3b5f024cdbdc9846d8;p=platform%2Fkernel%2Flinux-rpi.git i2c: amd-mp2: Remove useless DMA-32 fallback configuration As stated in [1], dma_set_mask() with a 64-bit mask never fails if dev->dma_mask is non-NULL. So, if it fails, the 32 bits case will also fail for the same reason. Simplify code and remove some dead code accordingly. [1]: https://lkml.org/lkml/2021/6/7/398 Signed-off-by: Christophe JAILLET Acked-by: Nehal Bakulchandra Shah Signed-off-by: Wolfram Sang --- diff --git a/drivers/i2c/busses/i2c-amd-mp2-pci.c b/drivers/i2c/busses/i2c-amd-mp2-pci.c index adf0e8c..f57077a 100644 --- a/drivers/i2c/busses/i2c-amd-mp2-pci.c +++ b/drivers/i2c/busses/i2c-amd-mp2-pci.c @@ -308,11 +308,8 @@ static int amd_mp2_pci_init(struct amd_mp2_dev *privdata, pci_set_master(pci_dev); rc = dma_set_mask(&pci_dev->dev, DMA_BIT_MASK(64)); - if (rc) { - rc = dma_set_mask(&pci_dev->dev, DMA_BIT_MASK(32)); - if (rc) - goto err_dma_mask; - } + if (rc) + goto err_dma_mask; /* Set up intx irq */ writel(0, privdata->mmio + AMD_P2C_MSG_INTEN);