From: bridiver <github@brianjohnson.cc>
Date: Wed, 10 Aug 2016 21:47:05 +0000 (-0700)
Subject: don't convert a string to an array buffer
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=94c60379d10f1c6b82a165db4547dec207fde590;p=platform%2Fframework%2Fweb%2Fcrosswalk-tizen.git

don't convert a string to an array buffer
---

diff --git a/atom/common/native_mate_converters/net_converter.cc b/atom/common/native_mate_converters/net_converter.cc
index e79e09d..bc97f3a 100644
--- a/atom/common/native_mate_converters/net_converter.cc
+++ b/atom/common/native_mate_converters/net_converter.cc
@@ -42,10 +42,7 @@ v8::Local<v8::Value> Converter<scoped_refptr<net::X509Certificate>>::ToV8(
   std::string encoded_data;
   net::X509Certificate::GetPEMEncoded(
       val->os_cert_handle(), &encoded_data);
-  auto buffer = node::Buffer::Copy(isolate,
-                                   encoded_data.data(),
-                                   encoded_data.size()).ToLocalChecked();
-  dict.Set("data", buffer);
+  dict.Set("data", encoded_data);
   dict.Set("issuerName", val->issuer().GetDisplayName());
   dict.Set("subjectName", val->subject().GetDisplayName());
   dict.Set("serialNumber", base::HexEncode(val->serial_number().data(),
diff --git a/docs/api/app.md b/docs/api/app.md
index c1aa274..1fb446a 100644
--- a/docs/api/app.md
+++ b/docs/api/app.md
@@ -178,7 +178,7 @@ Returns:
 * `url` URL
 * `error` String - The error code
 * `certificate` Object
-  * `data` Buffer - PEM encoded data
+  * `data` String - PEM encoded data
   * `issuerName` String - Issuer's Common Name
   * `subjectName` String - Subject's Common Name
   * `serialNumber` String - Hex value represented string
@@ -213,7 +213,7 @@ Returns:
 * `webContents` [WebContents](web-contents.md)
 * `url` URL
 * `certificateList` [Objects]
-  * `data` Buffer - PEM encoded data
+  * `data` String - PEM encoded data
   * `issuerName` String - Issuer's Common Name
   * `subjectName` String - Subject's Common Name
   * `serialNumber` String - Hex value represented string
diff --git a/docs/api/web-contents.md b/docs/api/web-contents.md
index f000193..6890336 100644
--- a/docs/api/web-contents.md
+++ b/docs/api/web-contents.md
@@ -230,7 +230,7 @@ Returns:
 * `url` URL
 * `error` String - The error code
 * `certificate` Object
-  * `data` Buffer - PEM encoded data
+  * `data` String - PEM encoded data
   * `issuerName` String - Issuer's Common Name
   * `subjectName` String - Subject's Common Name
   * `serialNumber` String - Hex value represented string
@@ -251,7 +251,7 @@ Returns:
 * `event` Event
 * `url` URL
 * `certificateList` [Objects]
-  * `data` Buffer - PEM encoded data
+  * `data` String - PEM encoded data
   * `issuerName` String - Issuer's Common Name
   * `subjectName` String - Subject's Common Name
   * `serialNumber` String - Hex value represented string