From: Patrick McHardy Date: Mon, 10 Mar 2008 23:45:05 +0000 (-0700) Subject: [NETFILTER]: nf_queue: don't return error when unregistering a non-existant handler X-Git-Tag: v3.12-rc1~22171^2~132 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=94be1a3f365e2b9f2615575d7fef16a0bad106a3;p=kernel%2Fkernel-generic.git [NETFILTER]: nf_queue: don't return error when unregistering a non-existant handler Commit ce7663d84: [NETFILTER]: nfnetlink_queue: don't unregister handler of other subsystem changed nf_unregister_queue_handler to return an error when attempting to unregister a queue handler that is not identical to the one passed in. This is correct in case we really do have a different queue handler already registered, but some existing userspace code always does an unbind before bind and aborts if that fails, so try to be nice and return success in that case. Signed-off-by: Patrick McHardy Signed-off-by: David S. Miller --- diff --git a/net/netfilter/nf_queue.c b/net/netfilter/nf_queue.c index bfc2928..ddc80ea 100644 --- a/net/netfilter/nf_queue.c +++ b/net/netfilter/nf_queue.c @@ -51,7 +51,7 @@ int nf_unregister_queue_handler(int pf, const struct nf_queue_handler *qh) return -EINVAL; mutex_lock(&queue_handler_mutex); - if (queue_handler[pf] != qh) { + if (queue_handler[pf] && queue_handler[pf] != qh) { mutex_unlock(&queue_handler_mutex); return -EINVAL; }