From: Dave Lee <davelee.com@gmail.com>
Date: Fri, 11 Mar 2022 20:45:47 +0000 (-0800)
Subject: [lldb] Removed scoped timer from ReadMemoryFromFileCache
X-Git-Tag: upstream/15.0.7~13885
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=94bda3aaa12192660cd8da3a7b3bf9749b2a2c44;p=platform%2Fupstream%2Fllvm.git

[lldb] Removed scoped timer from ReadMemoryFromFileCache

`ReadMemoryFromFileCache` can be called at a high rate, and has fast execution.
Signposts for high rate & brief duration can have a negative impact on tracing;
emitting a high volume signposts can lead to blocking, affecting performance,
and total volume makes human review of the trace harder because of the noise.

Differential Revision: https://reviews.llvm.org/D121226
---

diff --git a/lldb/source/Target/Target.cpp b/lldb/source/Target/Target.cpp
index 6e8cc1d..31e6cdb 100644
--- a/lldb/source/Target/Target.cpp
+++ b/lldb/source/Target/Target.cpp
@@ -1684,7 +1684,6 @@ bool Target::ModuleIsExcludedForUnconstrainedSearches(
 
 size_t Target::ReadMemoryFromFileCache(const Address &addr, void *dst,
                                        size_t dst_len, Status &error) {
-  LLDB_SCOPED_TIMER();
   SectionSP section_sp(addr.GetSection());
   if (section_sp) {
     // If the contents of this section are encrypted, the on-disk file is