From: Mauro Carvalho Chehab Date: Mon, 29 Oct 2012 09:58:59 +0000 (-0200) Subject: [media] drxk_hard: fix the return code from an error handler X-Git-Tag: v3.9-rc5~2^2~744 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=94af1b63d866289aabad0514f5c8ecf223f502fb;p=platform%2Fkernel%2Flinux-3.10.git [media] drxk_hard: fix the return code from an error handler While it is very unlikely, if the number of parameters for QAMDemodulatorCommand is not 2 or 4, status become undefined: /home/hans/work/build/v4l-dvb-git/drivers/media/dvb-frontends/drxk_hard.c: In function ‘QAMDemodulatorCommand’: /home/hans/work/build/v4l-dvb-git/drivers/media/dvb-frontends/drxk_hard.c:5452:5: warning: ‘status’ may be used uninitialized in this function [-Wuninitialized] Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/dvb-frontends/drxk_hard.c b/drivers/media/dvb-frontends/drxk_hard.c index 59382fb..76a4e5c 100644 --- a/drivers/media/dvb-frontends/drxk_hard.c +++ b/drivers/media/dvb-frontends/drxk_hard.c @@ -5446,6 +5446,7 @@ static int QAMDemodulatorCommand(struct drxk_state *state, } else { printk(KERN_WARNING "drxk: Unknown QAM demodulator parameter " "count %d\n", numberOfParameters); + status = -EINVAL; } error: