From: Paul Kirth Date: Tue, 19 Jul 2022 22:55:41 +0000 (+0000) Subject: [clang-doc] Reduce duplicate code with template X-Git-Tag: upstream/17.0.6~19491 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9470de65bb33a18842d64ab2ab777902613ee014;p=platform%2Fupstream%2Fllvm.git [clang-doc] Reduce duplicate code with template Reviewed By: phosek Differential Revision: https://reviews.llvm.org/D142564 --- diff --git a/clang-tools-extra/clang-doc/Representation.cpp b/clang-tools-extra/clang-doc/Representation.cpp index 31bb07d..3d078d5 100644 --- a/clang-tools-extra/clang-doc/Representation.cpp +++ b/clang-tools-extra/clang-doc/Representation.cpp @@ -54,51 +54,16 @@ int getChildIndexIfExists(std::vector &Children, T &ChildToMerge) { return -1; } -void reduceChildren(std::vector &Children, - std::vector &&ChildrenToMerge) { - for (auto &ChildToMerge : ChildrenToMerge) { - int mergeIdx = getChildIndexIfExists(Children, ChildToMerge); - if (mergeIdx == -1) { - Children.push_back(std::move(ChildToMerge)); - continue; - } - Children[mergeIdx].merge(std::move(ChildToMerge)); - } -} - -void reduceChildren(std::vector &Children, - std::vector &&ChildrenToMerge) { - for (auto &ChildToMerge : ChildrenToMerge) { - int mergeIdx = getChildIndexIfExists(Children, ChildToMerge); - if (mergeIdx == -1) { - Children.push_back(std::move(ChildToMerge)); - continue; - } - Children[mergeIdx].merge(std::move(ChildToMerge)); - } -} - -void reduceChildren(std::vector &Children, - std::vector &&ChildrenToMerge) { - for (auto &ChildToMerge : ChildrenToMerge) { - int mergeIdx = getChildIndexIfExists(Children, ChildToMerge); - if (mergeIdx == -1) { - Children.push_back(std::move(ChildToMerge)); - continue; - } - Children[mergeIdx].merge(std::move(ChildToMerge)); - } -} - -void reduceChildren(std::vector &Children, - std::vector &&ChildrenToMerge) { +template +void reduceChildren(std::vector &Children, + std::vector &&ChildrenToMerge) { for (auto &ChildToMerge : ChildrenToMerge) { - int mergeIdx = getChildIndexIfExists(Children, ChildToMerge); - if (mergeIdx == -1) { + int MergeIdx = getChildIndexIfExists(Children, ChildToMerge); + if (MergeIdx == -1) { Children.push_back(std::move(ChildToMerge)); continue; } - Children[mergeIdx].merge(std::move(ChildToMerge)); + Children[MergeIdx].merge(std::move(ChildToMerge)); } }