From: Karthik <kv.bhat@samsung.com>
Date: Fri, 30 Jul 2021 11:56:51 +0000 (+0530)
Subject: Fix on-demand installation failure
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9428cdae2631fe1b89fe6526d4d10679977f8912;p=sdk%2Femulator%2Fqemu.git

Fix on-demand installation failure

Change-Id: Ic9bd76cd874d395593f0a46a322f394f890a6055
Signed-off-by: Karthik <kv.bhat@samsung.com>
---

diff --git a/tizen/src/util/extra_pkgs_install.c b/tizen/src/util/extra_pkgs_install.c
index 7f033ca..8e30592 100644
--- a/tizen/src/util/extra_pkgs_install.c
+++ b/tizen/src/util/extra_pkgs_install.c
@@ -80,12 +80,15 @@ static char *get_addon_path(void)
     return extra_path;
 }
 
-static void add_addon_pkgs_name(char *pkgs, char *name, size_t size)
+static void add_addon_pkgs_name(char *pkgs, char *name)
 {
-    if (strlen(pkgs) == 0) {
-        strncpy(pkgs, name, size);
+    int len = strlen(pkgs);
+    if (len == 0) {
+        strncpy(pkgs, name, MAX_PKG_LIST-1);
     } else {
-        snprintf(pkgs, size, "%s, %s", pkgs, name);
+        char pkg[MAX_PKG_LIST];
+        snprintf(pkg, MAX_PKG_LIST, ", %s", name);
+        strncat(pkgs,pkg,MAX_PKG_LIST-len-1);
     }
 }
 
@@ -225,8 +228,8 @@ void epi_init(void)
                     }
 
                     pkg_count++;
-                    add_addon_pkgs_name(pkgs, sub_dir_entry->d_name, sizeof(pkgs));
-                    add_addon_pkgs_name(pkg_list, sub_dir_entry->d_name, sizeof(pkg_list));
+                    add_addon_pkgs_name(pkgs, sub_dir_entry->d_name);
+                    add_addon_pkgs_name(pkg_list, sub_dir_entry->d_name);
                     LOG_TRACE("reading addon sub directory: %s\n", sub_dir_entry->d_name);
                 }
             }