From: Ming Lei Date: Fri, 15 Mar 2013 04:08:54 +0000 (+0800) Subject: USB: serial: comments on suspend failure X-Git-Tag: v3.12-rc1~998^2~224 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=93e4f47f4d1a3483f009202e8a66a3a08de5c4b6;p=kernel%2Fkernel-generic.git USB: serial: comments on suspend failure If suspend callback fails in system sleep context, usb core will ignore the failure and let system sleep go ahead further, so this patch comments on the case and requires that serial->type->suspend() MUST return 0 in system sleep context. Acked-by: Johan Hovold Signed-off-by: Ming Lei Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c index bbe7f2e..2fc0500 100644 --- a/drivers/usb/serial/usb-serial.c +++ b/drivers/usb/serial/usb-serial.c @@ -1137,6 +1137,11 @@ int usb_serial_suspend(struct usb_interface *intf, pm_message_t message) serial->suspending = 1; + /* + * serial->type->suspend() MUST return 0 in system sleep context, + * otherwise, the resume callback has to recover device from + * previous suspend failure. + */ if (serial->type->suspend) { r = serial->type->suspend(serial, message); if (r < 0) {