From: Kevin Wolf Date: Sat, 19 Dec 2009 20:15:20 +0000 (+0100) Subject: Multiboot support: Fix rom_copy X-Git-Tag: TizenStudio_2.0_p2.3.2~208^2~9206 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=935effc2bbd2c441b755a8d280811a9763fdb98c;p=sdk%2Femulator%2Fqemu.git Multiboot support: Fix rom_copy ROMs need to be loaded if they are anywhere in the requested area, not only at the very beginning. This fixes Multiboot with ELF kernels that have more than one program header. Signed-off-by: Kevin Wolf Signed-off-by: Aurelien Jarno --- diff --git a/hw/loader.c b/hw/loader.c index c7d43f6..2ceb8eb 100644 --- a/hw/loader.c +++ b/hw/loader.c @@ -698,6 +698,11 @@ static Rom *find_rom(target_phys_addr_t addr) return NULL; } +/* + * Copies memory from registered ROMs to dest. Any memory that is contained in + * a ROM between addr and addr + size is copied. Note that this can involve + * multiple ROMs, which need not start at addr and need not end at addr + size. + */ int rom_copy(uint8_t *dest, target_phys_addr_t addr, size_t size) { target_phys_addr_t end = addr + size; @@ -706,8 +711,6 @@ int rom_copy(uint8_t *dest, target_phys_addr_t addr, size_t size) Rom *rom; QTAILQ_FOREACH(rom, &roms, next) { - if (rom->addr > addr) - continue; if (rom->addr + rom->romsize < addr) continue; if (rom->addr > end)