From: Colin Ian King Date: Wed, 1 Nov 2017 10:49:23 +0000 (+0000) Subject: serial: core: remove redundant assignment to port X-Git-Tag: v4.19~2225^2~23 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9356335faf9f65568dbdb9bba2a07117f69d34c5;p=platform%2Fkernel%2Flinux-rpi.git serial: core: remove redundant assignment to port The final assignment to port is never read, hence it is redundant and can be removed. Also move the declaration of port to a more local scope. Cleans up clang warning: drivers/tty/serial/serial_core.c:1498:2: warning: Value stored to 'port' is never read Signed-off-by: Colin Ian King Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c index f4e6c866..cdac01f 100644 --- a/drivers/tty/serial/serial_core.c +++ b/drivers/tty/serial/serial_core.c @@ -1482,10 +1482,10 @@ out: static void uart_close(struct tty_struct *tty, struct file *filp) { struct uart_state *state = tty->driver_data; - struct tty_port *port; if (!state) { struct uart_driver *drv = tty->driver->driver_state; + struct tty_port *port; state = drv->state + tty->index; port = &state->port; @@ -1495,7 +1495,6 @@ static void uart_close(struct tty_struct *tty, struct file *filp) return; } - port = &state->port; pr_debug("uart_close(%d) called\n", tty->index); tty_port_close(tty->port, tty, filp);