From: Dan Carpenter Date: Thu, 25 Aug 2022 13:17:19 +0000 (+0300) Subject: net: fman: memac: Uninitialized variable on error path X-Git-Tag: v6.6.17~6504^2~319 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=931d0a8b201a46aedb7767087438ea9e4467b6cd;p=platform%2Fkernel%2Flinux-rpi.git net: fman: memac: Uninitialized variable on error path The "fixed_link" is only allocated sometimes but it's freed unconditionally in the error handling. Set it to NULL so we don't free uninitialized data. Fixes: 9ea4742a55ca ("net: fman: Configure fixed link in memac_initialization") Signed-off-by: Dan Carpenter Reviewed-by: Sean Anderson Link: https://lore.kernel.org/r/Ywd2X6gdKmTfYBxD@kili Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/ethernet/freescale/fman/mac.c b/drivers/net/ethernet/freescale/fman/mac.c index c376b9b..f9a3f85 100644 --- a/drivers/net/ethernet/freescale/fman/mac.c +++ b/drivers/net/ethernet/freescale/fman/mac.c @@ -389,7 +389,7 @@ static int memac_initialization(struct mac_device *mac_dev, { int err; struct fman_mac_params params; - struct fixed_phy_status *fixed_link; + struct fixed_phy_status *fixed_link = NULL; mac_dev->set_promisc = memac_set_promiscuous; mac_dev->change_addr = memac_modify_mac_address;