From: Shinwoo Kim <cinoo.kim@samsung.com>
Date: Fri, 16 Mar 2018 13:15:54 +0000 (+0900)
Subject: atspi: do not expose name of PASSWORD_TEXT
X-Git-Tag: submit/tizen_4.0/20180328.070153~3
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=930ffefa2b3b443413b29dda63f35b7091f2449f;p=platform%2Fupstream%2Felementary.git

atspi: do not expose name of PASSWORD_TEXT

The AT-client could get the name of PASSWORD_TEXT.
This could be fixed in _elm_entry_elm_interface_atspi_accessible_name_get,
but user defined accessible name should be accessible by the AT-client,
so _elm_widget_elm_interface_atspi_accessible_name_get is proper place.

Change-Id: I7ababb86e60dedb6882662dca6f66e35bba20024
---

diff --git a/src/lib/elm_entry.c b/src/lib/elm_entry.c
index 05841889e..cf3baf4a5 100644
--- a/src/lib/elm_entry.c
+++ b/src/lib/elm_entry.c
@@ -7847,10 +7847,15 @@ _elm_entry_elm_interface_atspi_accessible_name_get(Eo *obj, Elm_Entry_Data *sd)
    eo_do_super(obj, ELM_ENTRY_CLASS, name = elm_interface_atspi_accessible_name_get());
    if (name && strncmp("", name, 1)) return name;
 
-   if (sd->password) return NULL;
-
-   name = _elm_widget_accessible_plain_name_get(obj, elm_entry_entry_get(obj));
-   if (name && strncmp("", name, 1)) return name;
+   if (sd->password)
+     {
+        if (sd->has_text) return NULL;
+     }
+   else
+     {
+        name = _elm_widget_accessible_plain_name_get(obj, elm_entry_entry_get(obj));
+        if (name && strncmp("", name, 1)) return name;
+     }
 
    const char *ret = edje_object_part_text_get(sd->entry_edje, "elm.guide");
    return _elm_widget_accessible_plain_name_get(obj, ret);
diff --git a/src/lib/elm_widget.c b/src/lib/elm_widget.c
index 3e26ecbd6..85a678241 100644
--- a/src/lib/elm_widget.c
+++ b/src/lib/elm_widget.c
@@ -6685,7 +6685,7 @@ _elm_widget_elm_interface_atspi_accessible_name_get(Eo *obj, Elm_Widget_Smart_Da
    //TIZEN_ONLY(20170110) : Ignore text from elm_object_text_set in accessible_name_get
    Elm_Atspi_Role role;
    eo_do(obj, role = elm_interface_atspi_accessible_role_get());
-   if(role == ELM_ATSPI_ROLE_DIALOG)
+   if(role == ELM_ATSPI_ROLE_DIALOG || role == ELM_ATSPI_ROLE_PASSWORD_TEXT)
      return NULL;
    //