From: Nicolas Iooss Date: Sat, 26 Nov 2016 19:43:50 +0000 (-0200) Subject: [media] tw686x: silent -Wformat-security warning X-Git-Tag: v4.14-rc1~332^2~818 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=92fbeb40b132f5b2ec335f644ba563a1a85ffd8b;p=platform%2Fkernel%2Flinux-rpi3.git [media] tw686x: silent -Wformat-security warning Using sprintf() with a non-literal string makes some compiler complain when building with -Wformat-security (eg. clang reports "format string is not a string literal (potentially insecure)"). Here sprintf() format parameter is indirectly a literal string so there is no security issue. Nevertheless adding a "%s" format string to silent the warning helps to detect real bugs in the kernel. Signed-off-by: Nicolas Iooss Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/pci/tw686x/tw686x-core.c b/drivers/media/pci/tw686x/tw686x-core.c index 71a0453..336e2f9 100644 --- a/drivers/media/pci/tw686x/tw686x-core.c +++ b/drivers/media/pci/tw686x/tw686x-core.c @@ -74,7 +74,7 @@ static const char *dma_mode_name(unsigned int mode) static int tw686x_dma_mode_get(char *buffer, struct kernel_param *kp) { - return sprintf(buffer, dma_mode_name(dma_mode)); + return sprintf(buffer, "%s", dma_mode_name(dma_mode)); } static int tw686x_dma_mode_set(const char *val, struct kernel_param *kp)