From: commit-queue@webkit.org Date: Tue, 26 Jun 2012 01:26:17 +0000 (+0000) Subject: Reduce memory footprint of BitmapImage Vectors. X-Git-Tag: 070512121124~678 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=92d86b0becc931d5a7d1fbf9af2ed41cbfcaade6;p=profile%2Fivi%2Fwebkit-efl.git Reduce memory footprint of BitmapImage Vectors. https://bugs.webkit.org/show_bug.cgi?id=86563 Patch by Nick Carter on 2012-06-25 Reviewed by Simon Fraser. No new tests, affects template params only. * platform/graphics/BitmapImage.h: (BitmapImage): use an inline capacity of 1 for the image frame Vector * platform/image-decoders/ImageDecoder.h: (ImageDecoder): use an inline capacity of 1 for the image frame Vector git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121208 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog index 40fd2f5..f34420c 100644 --- a/Source/WebCore/ChangeLog +++ b/Source/WebCore/ChangeLog @@ -1,3 +1,17 @@ +2012-06-25 Nick Carter + + Reduce memory footprint of BitmapImage Vectors. + https://bugs.webkit.org/show_bug.cgi?id=86563 + + Reviewed by Simon Fraser. + + No new tests, affects template params only. + + * platform/graphics/BitmapImage.h: + (BitmapImage): use an inline capacity of 1 for the image frame Vector + * platform/image-decoders/ImageDecoder.h: + (ImageDecoder): use an inline capacity of 1 for the image frame Vector + 2012-06-25 Kent Tamura Unreviewed, rolling out r121145. diff --git a/Source/WebCore/platform/graphics/BitmapImage.h b/Source/WebCore/platform/graphics/BitmapImage.h index 2f1969e..64c81c7 100644 --- a/Source/WebCore/platform/graphics/BitmapImage.h +++ b/Source/WebCore/platform/graphics/BitmapImage.h @@ -272,8 +272,8 @@ protected: mutable IntSize m_sizeRespectingOrientation; size_t m_currentFrame; // The index of the current frame of animation. - Vector m_frames; // An array of the cached frames of the animation. We have to ref frames to pin them in the cache. - + Vector m_frames; // An array of the cached frames of the animation. We have to ref frames to pin them in the cache. + Timer* m_frameTimer; int m_repetitionCount; // How many total animation loops we should do. This will be cAnimationNone if this image type is incapable of animation. RepetitionCountStatus m_repetitionCountStatus; diff --git a/Source/WebCore/platform/image-decoders/ImageDecoder.h b/Source/WebCore/platform/image-decoders/ImageDecoder.h index e92ba7d..2611be9 100644 --- a/Source/WebCore/platform/image-decoders/ImageDecoder.h +++ b/Source/WebCore/platform/image-decoders/ImageDecoder.h @@ -362,7 +362,7 @@ namespace WebCore { int scaledY(int origY, int searchStart = 0); RefPtr m_data; // The encoded data. - Vector m_frameBufferCache; + Vector m_frameBufferCache; // FIXME: Do we need m_colorProfile any more, for any port? ColorProfile m_colorProfile; bool m_scaled;