From: mk5004.lee Date: Fri, 15 Mar 2019 02:19:16 +0000 (+0900) Subject: Update behavior of VisibilityAction::Execute X-Git-Tag: submit/tizen/20190326.074206~22 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=92c1adfed030b07412375a0beafe2a44b98e27c4;p=platform%2Fcore%2Fapi%2Fnotification.git Update behavior of VisibilityAction::Execute Change-Id: I9be1d98d6c4ff65ce28748b1d7739155cd0f7372 Signed-off-by: mk5004.lee --- diff --git a/notification-ex/visibility_action.cc b/notification-ex/visibility_action.cc index 99fba847..65d7cbf0 100644 --- a/notification-ex/visibility_action.cc +++ b/notification-ex/visibility_action.cc @@ -108,16 +108,10 @@ bool VisibilityAction::IsLocal() const { } void VisibilityAction::Execute(std::shared_ptr item) { - std::string id = item->GetId(); - std::list>::iterator it; - - for (it = impl_->entities_.begin(); it != impl_->entities_.end(); it++) { - if (id == (*it)->id_) { - if ((*it)->visibility_) - (*it)->visibility_ = false; - else - (*it)->visibility_ = true; - } + for (const auto& entity : impl_->entities_) { + AbstractItem& item_ = item->FindByID(entity->id_); + if (item_.GetType() != AbstractItem::NullObject) + item_.SetVisible(entity->visibility_); } }