From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 2 Jul 2015 16:38:12 +0000 (+0200)
Subject: netlink: Delete an unnecessary check before the function call "module_put"
X-Git-Tag: v4.9.8~3909^2~41
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=92b80eb33c52583b48ed289bd993579b87b52d9a;p=platform%2Fkernel%2Flinux-rpi3.git

netlink: Delete an unnecessary check before the function call "module_put"

The module_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index dea9253..9a0ae71 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -158,7 +158,7 @@ static int __netlink_remove_tap(struct netlink_tap *nt)
 out:
 	spin_unlock(&netlink_tap_lock);
 
-	if (found && nt->module)
+	if (found)
 		module_put(nt->module);
 
 	return found ? 0 : -ENODEV;