From: Bruno Prémont Date: Sun, 21 Dec 2014 16:43:44 +0000 (+0100) Subject: drm/msm: Do not BUG_ON(!spin_is_locked()) on UP X-Git-Tag: v4.0-rc1~74^2~11^2~17 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=925c1e7f716e14c848676ff70a442fe9e80d6e75;p=platform%2Fkernel%2Flinux-exynos.git drm/msm: Do not BUG_ON(!spin_is_locked()) on UP On !SMP systems spinlocks do not exist. Thus checking of they are active will always fail. Use assert_spin_locked(lock); instead of BUG_ON(!spin_is_locked(lock)); to not BUG() on all UP systems. Signed-off-by: Bruno Prémont [robclark: drop stray ')'] Signed-off-by: Rob Clark --- diff --git a/drivers/gpu/drm/msm/mdp/mdp_kms.c b/drivers/gpu/drm/msm/mdp/mdp_kms.c index 2a73172..1988c24 100644 --- a/drivers/gpu/drm/msm/mdp/mdp_kms.c +++ b/drivers/gpu/drm/msm/mdp/mdp_kms.c @@ -34,7 +34,7 @@ static void update_irq(struct mdp_kms *mdp_kms) struct mdp_irq *irq; uint32_t irqmask = mdp_kms->vblank_mask; - BUG_ON(!spin_is_locked(&list_lock)); + assert_spin_locked(&list_lock); list_for_each_entry(irq, &mdp_kms->irq_list, node) irqmask |= irq->irqmask;