From: Alexander Köplinger Date: Wed, 19 Jul 2023 12:01:05 +0000 (+0200) Subject: Fix outerloop tests in System.Formats.Tar (#89172) X-Git-Tag: accepted/tizen/unified/riscv/20231226.055536~898 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=924668cc69da2fcfac0b191da8849b5401fcebd7;p=platform%2Fupstream%2Fdotnet%2Fruntime.git Fix outerloop tests in System.Formats.Tar (#89172) The change from https://github.com/dotnet/runtime/pull/88280 caused an issue when discovering the test: ``` System.InvalidOperationException : An appropriate member 'ManualTestsEnabled' could not be found. The conditional method needs to be a static method, property, or field on the type System.Formats.Tar.Tests.ManualTestsAsync or any ancestor, of any visibility, accepting zero arguments, and having a return type of Boolean. ``` --- diff --git a/src/libraries/System.Formats.Tar/tests/Manual/ManualTestsAsync.cs b/src/libraries/System.Formats.Tar/tests/Manual/ManualTestsAsync.cs index 5262c71..445502d 100644 --- a/src/libraries/System.Formats.Tar/tests/Manual/ManualTestsAsync.cs +++ b/src/libraries/System.Formats.Tar/tests/Manual/ManualTestsAsync.cs @@ -16,7 +16,7 @@ public class ManualTestsAsync : TarTestsBase // Fixes error xUnit1015: MemberData needs to be in the same class => ManualTests.WriteEntry_LongFileSize_TheoryData(); - [ConditionalTheory(nameof(ManualTests.ManualTestsEnabled))] + [ConditionalTheory(typeof(ManualTests), nameof(ManualTests.ManualTestsEnabled))] [MemberData(nameof(WriteEntry_LongFileSize_TheoryDataAsync))] [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.Android | TestPlatforms.Browser, "Needs too much disk space.")] public async Task WriteEntry_LongFileSizeAsync(TarEntryFormat entryFormat, long size, bool unseekableStream)