From: Barnabás Pőcze Date: Wed, 3 Feb 2021 21:56:44 +0000 (+0000) Subject: Revert "platform/x86: ideapad-laptop: Switch touchpad attribute to be RO" X-Git-Tag: v5.15~1725^2~19 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=921f70ffe8901f98f7552194cc0458c4a145145e;p=platform%2Fkernel%2Flinux-starfive.git Revert "platform/x86: ideapad-laptop: Switch touchpad attribute to be RO" The touchpad can be enabled/disabled via this attribute on a Lenovo Yoga 520-14IKB. Allow writing as it provides legitimate functionality. This reverts commit 7f363145992cebf4ea760447f1cfdf6f81459683. Signed-off-by: Barnabás Pőcze Reviewed-by: Hans de Goede Reviewed-by: Andy Shevchenko Link: https://lore.kernel.org/r/20210203215403.290792-24-pobrn@protonmail.com Signed-off-by: Hans de Goede --- diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c index a89588f..4cecf3b 100644 --- a/drivers/platform/x86/ideapad-laptop.c +++ b/drivers/platform/x86/ideapad-laptop.c @@ -462,10 +462,9 @@ static ssize_t touchpad_show(struct device *dev, return sysfs_emit(buf, "%d\n", !!result); } -/* Switch to RO for now: It might be revisited in the future */ -static ssize_t __maybe_unused touchpad_store(struct device *dev, - struct device_attribute *attr, - const char *buf, size_t count) +static ssize_t touchpad_store(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t count) { struct ideapad_private *priv = dev_get_drvdata(dev); bool state; @@ -481,7 +480,7 @@ static ssize_t __maybe_unused touchpad_store(struct device *dev, return count; } -static DEVICE_ATTR_RO(touchpad); +static DEVICE_ATTR_RW(touchpad); static ssize_t conservation_mode_show(struct device *dev, struct device_attribute *attr,