From: Eliad Peller Date: Sun, 5 Jan 2014 10:41:12 +0000 (+0200) Subject: iwlwifi: mvm: fix missing cleanup in .start() error path X-Git-Tag: upstream/snapshot3+hdmi~3572^2~3^2^2~5^2~16 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=91b0d1198417cf4fd9a7bd4138b6909f0b359099;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git iwlwifi: mvm: fix missing cleanup in .start() error path Cleanup of iwl_mvm_leds was missing in case of error, resulting in the following warning: WARNING: at lib/kobject.c:196 kobject_add_internal+0x1f4/0x210() kobject_add_internal failed for phy0-led with -EEXIST, don't try to register things with the same name in the same directory. which prevents further reloads of the driver. Cc: stable@vger.kernel.org [3.10+] Signed-off-by: Eliad Peller Signed-off-by: Emmanuel Grumbach --- diff --git a/drivers/net/wireless/iwlwifi/mvm/ops.c b/drivers/net/wireless/iwlwifi/mvm/ops.c index 552c76a..2437a06 100644 --- a/drivers/net/wireless/iwlwifi/mvm/ops.c +++ b/drivers/net/wireless/iwlwifi/mvm/ops.c @@ -472,6 +472,7 @@ iwl_op_mode_mvm_start(struct iwl_trans *trans, const struct iwl_cfg *cfg, out_unregister: ieee80211_unregister_hw(mvm->hw); + iwl_mvm_leds_exit(mvm); out_free: iwl_phy_db_free(mvm->phy_db); kfree(mvm->scan_cmd);