From: Maciej W. Rozycki <macro@imgtec.com>
Date: Tue, 11 Apr 2017 23:02:13 +0000 (+0100)
Subject: MIPS/readelf: Remove extraneous null GOT data check
X-Git-Tag: binutils-2_29~695
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=919383ac718c2a3187ee2a9ad659daa22da26258;p=platform%2Fupstream%2Fbinutils.git

MIPS/readelf: Remove extraneous null GOT data check

Null data is handled gracefully throughout in MIPS GOT processing, with
addresses printed normally and unavailable data shown as `<unknown>' by
`print_mips_got_entry', and special processing code for GOT[1] doing an
explicit check.  Remove an unwanted null GOT data check then, introduced
with commit 592458412fb2 in the course of addressing PR binutils/12855.

	binutils/
	* readelf.c (process_mips_specific): Remove null GOT data check.
---

diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index d5b515f..0b6a712 100644
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,5 +1,9 @@
 2017-04-25  Maciej W. Rozycki  <macro@imgtec.com>
 
+	* readelf.c (process_mips_specific): Remove null GOT data check.
+
+2017-04-25  Maciej W. Rozycki  <macro@imgtec.com>
+
 	* testsuite/binutils-all/mips/mips16-alias.d: New test.
 	* testsuite/binutils-all/mips/mips16-noalias.d: New test.
 	* testsuite/binutils-all/mips/mips16-alias.s: New test source.
diff --git a/binutils/readelf.c b/binutils/readelf.c
index e575667..d4c4137 100644
--- a/binutils/readelf.c
+++ b/binutils/readelf.c
@@ -15483,8 +15483,7 @@ process_mips_specific (FILE * file)
       data = (unsigned char *) get_data (NULL, file, offset,
                                          global_end - pltgot, 1,
 					 _("Global Offset Table data"));
-      if (data == NULL)
-	return FALSE;
+      /* PR 12855: Null data is handled gracefully throughout.  */
       data_end = data + (global_end - pltgot);
 
       printf (_("\nPrimary GOT:\n"));